Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): Add @rsjf/ monorepo #21423

Closed
wants to merge 2 commits into from
Closed

Conversation

hawkrives
Copy link

@hawkrives hawkrives commented Apr 11, 2023

Changes

I added a monorepo, @rjsf/*core*, for the react-json-schema-form packages.

Context

I was going to put this in locally, but I realized that I should just contribute the new monorepo back to core!

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

I believe that this updates the documentation automatically.

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@hawkrives hawkrives changed the title Add @rsjf/ monorepo feat(presets): Add @rsjf/ monorepo Apr 11, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please validate that those packages do have correctly published the repo url. probably test it on a repo with a package rule. otherwise LGTM

@hawkrives
Copy link
Author

Closing as #22248 was merged. Sorry that I didn't manage to come back to this!

@hawkrives hawkrives closed this May 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants