New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(composer): Use schema for parsing #21520
refactor(composer): Use schema for parsing #21520
Conversation
Data schemas for composer are quite complicated, because they support two parallel formats at the same time (array + record) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready or not ready for review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocked by other PR
# Conflicts: # lib/util/schema-utils.spec.ts # lib/util/schema-utils.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very big and hard to review. can we split to smaller parts?
I don't see a meaningful way to split it into different parts |
ok, so it'll need some time to review 🤷♂️ |
lib/modules/manager/composer/__snapshots__/extract.spec.ts.snap
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
🎉 This PR is included in version 35.73.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
JSON.parse
+ type castContext
@total-typescript/ts-reset
for better standard library types #20553Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: