Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(onboarding): don’t check onboarding cache unless onboarding=true #21967

Merged
merged 2 commits into from May 4, 2023
Merged

fix(onboarding): don’t check onboarding cache unless onboarding=true #21967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31af9da
fix(onboarding): don’t check onboarding cache unless onboarding is en…
rarkins May 4, 2023
afbe6b5
fix test
rarkins May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/workers/repository/onboarding/branch/check.spec.ts
View file
Open in desktop
Expand Up @@ -20,6 +20,7 @@ describe('workers/repository/onboarding/branch/check', () => {
const config = partial<RenovateConfig>({
requireConfig: 'required',
suppressNotifications: [],
onboarding: true,
});

it('skips normal onboarding check if onboardingCache is valid', async () => {
Expand Down
1 change: 1 addition & 0 deletions lib/workers/repository/onboarding/branch/check.ts
View file
Open in desktop
Expand Up @@ -68,6 +68,7 @@ export async function isOnboarded(config: RenovateConfig): Promise<boolean> {
// if onboarding cache is present and base branch has not been updated branch is not onboarded
// if closed pr exists then presence of onboarding cache doesn't matter as we need to skip onboarding
if (
config.onboarding &&
!pr &&
onboardingBranchCache &&
onboardingBranchCache.defaultBranchSha ===
Expand Down