Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(rubygems): Inline params for better readability #22017

Merged
merged 2 commits into from May 7, 2023
Merged

test(rubygems): Inline params for better readability #22017

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c135dfa
test(rubygems): Inline params for better readability
zharinov May 7, 2023
2b40c55
Merge branch 'main' into refactor/rubygems-test-inline-params
zharinov May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
158 changes: 112 additions & 46 deletions lib/modules/datasource/rubygems/index.spec.ts
View file
Open in desktop
Expand Up @@ -13,16 +13,6 @@ const emptyMarshalArray = Buffer.from([4, 8, 91, 0]);

describe('modules/datasource/rubygems/index', () => {
describe('getReleases', () => {
const params = {
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
};

beforeEach(() => {
memCache.clear();
jest.resetAllMocks();
Expand All @@ -42,51 +32,64 @@ describe('modules/datasource/rubygems/index', () => {
.scope('https://thirdparty.com')
.get('/api/v1/gems/rails.json')
.reply(200);
expect(await getPkgReleases(params)).toBeNull();
expect(
await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
})
).toBeNull();
});

it('returns null for rubygems.org package miss', async () => {
const newparams = { ...params };
newparams.registryUrls = [];
httpMock
.scope('https://rubygems.org')
.get('/versions')
.reply(404, rubygemsOrgVersions);
const res = await getPkgReleases(newparams);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [],
});
expect(res).toBeNull();
});

it('returns null for an error without "not_supported" reason', async () => {
const newparams = {
...params,
registryUrls: [],
};

const versionsdataSourceSpy = jest
.spyOn(VersionsDatasource.prototype, 'syncVersions')
.mockImplementationOnce(() => {
throw new Error();
});

try {
const res = await getPkgReleases(newparams);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [],
});
expect(res).toBeNull();
} finally {
versionsdataSourceSpy.mockRestore();
}
});

it('returns a dep for rubygems.org package hit', async () => {
const newparams = {
...params,
packageName: '1pass',
registryUrls: [],
};
httpMock
.scope('https://rubygems.org')
.get('/versions')
.reply(200, rubygemsOrgVersions);
const res = await getPkgReleases(newparams);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: '1pass',
registryUrls: [],
});
expect(res).not.toBeNull();
expect(res?.releases).toHaveLength(2);
expect(res).toMatchSnapshot();
Expand All @@ -104,16 +107,16 @@ describe('modules/datasource/rubygems/index', () => {
---
sidekiq-ent 0.7.10,1.0.0,1.0.1,1.2.4,2.0.0,2.1.2 4c0f62a49b15b4775b7fb6824ec34d45
`;
const newparams = {
...params,
packageName: 'sidekiq-ent',
registryUrls: ['https://enterprise.contribsys.com'],
};
httpMock
.scope('https://enterprise.contribsys.com')
.get('/versions')
.reply(200, contribsysComVersions);
const res = await getPkgReleases(newparams);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'sidekiq-ent',
registryUrls: ['https://enterprise.contribsys.com'],
});
expect(res).not.toBeNull();
expect(res?.releases).toHaveLength(6);
expect(res).toMatchObject({
Expand Down Expand Up @@ -143,13 +146,16 @@ describe('modules/datasource/rubygems/index', () => {

expect(
await getPkgReleases({
...params,
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [],
})
).toBeNull();

const res = await getPkgReleases({
...params,
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: '1pass',
registryUrls: [],
});
Expand All @@ -168,7 +174,15 @@ describe('modules/datasource/rubygems/index', () => {
.get('/api/v1/versions/rails.json')
.reply(200, railsVersions);

const res = await getPkgReleases(params);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
});
expect(res?.releases).toHaveLength(339);
expect(res).toMatchSnapshot();
});
Expand All @@ -189,7 +203,15 @@ describe('modules/datasource/rubygems/index', () => {
.get('/basepath/api/v1/versions/rails.json')
.reply(200, railsVersions);

const res = await getPkgReleases(params);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
});
expect(res?.releases).toHaveLength(339);
expect(res).toMatchSnapshot();
});
Expand All @@ -207,7 +229,17 @@ describe('modules/datasource/rubygems/index', () => {
.reply(404)
.get('/basepath/api/v1/gems/rails.json')
.reply(200);
expect(await getPkgReleases(params)).toBeNull();
expect(
await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
})
).toBeNull();
});

it('falls back to info when version request fails', async () => {
Expand All @@ -219,7 +251,15 @@ describe('modules/datasource/rubygems/index', () => {
.reply(200, railsInfo)
.get('/api/v1/versions/rails.json')
.reply(400, {});
const res = await getPkgReleases(params);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
});
expect(res?.releases).toHaveLength(1);
expect(res?.releases[0].version).toBe(railsInfo.version);
});
Expand All @@ -239,7 +279,17 @@ describe('modules/datasource/rubygems/index', () => {
.reply(404)
.get('/api/v1/gems/rails.json')
.reply(500);
expect(await getPkgReleases(params)).toBeNull();
expect(
await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
})
).toBeNull();
});

it('falls back to dependencies api', async () => {
Expand All @@ -252,32 +302,48 @@ describe('modules/datasource/rubygems/index', () => {
.get('/api/v1/dependencies?gems=rails')
.reply(200, railsDependencies);

const res = await getPkgReleases(params);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: [
'https://thirdparty.com',
'https://firstparty.com/basepath/',
],
});
expect(res?.releases).toHaveLength(339);
});

it('returns null for GitHub Packages package miss', async () => {
const newparams = { ...params };
newparams.registryUrls = ['https://rubygems.pkg.github.com/example'];
httpMock
.scope('https://rubygems.pkg.github.com/example')
.get('/versions')
.reply(404)
.get('/api/v1/dependencies?gems=rails')
.reply(200, emptyMarshalArray);
expect(await getPkgReleases(newparams)).toBeNull();
expect(
await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: ['https://rubygems.pkg.github.com/example'],
})
).toBeNull();
});

it('returns a dep for GitHub Packages package hit', async () => {
const newparams = { ...params };
newparams.registryUrls = ['https://rubygems.pkg.github.com/example'];
httpMock
.scope('https://rubygems.pkg.github.com/example')
.get('/versions')
.reply(404)
.get('/api/v1/dependencies?gems=rails')
.reply(200, railsDependencies);
const res = await getPkgReleases(newparams);
const res = await getPkgReleases({
versioning: rubyVersioning.id,
datasource: RubyGemsDatasource.id,
packageName: 'rails',
registryUrls: ['https://rubygems.pkg.github.com/example'],
});
expect(res?.releases).toHaveLength(339);
expect(res).toMatchSnapshot();
});
Expand Down