refactor: do not write packageFile content in updateArtifacts #22304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks at least the gradle artifact update - lockfiles are no longer updated. There are two calls to gradlew. The first one still needs the "old" package file in Reproducible with https://github.com/renovate-demo/20289-renovate-gradle-lock-file-example |
viceice
reviewed
May 19, 2023
| @@ -270,8 +269,6 @@ export async function updateArtifacts({ | |||
| config.constraints?.go ?? (await getGoConstraints(goModFileName)); | |||
|
|
|||
| try { | |||
| await writeLocalFile(goModFileName, massagedGoMod); | |||
There was a problem hiding this comment.
this needs revert, as we massage some go stuff to that file
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removes calls of
writeLocalFilefromupdateArtifacts, if the former only writes the content provided by the function parameter.Context
#22244 (comment)
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Needs still some e2e testing