refactor(npm): Use schema for datasource #22318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #22314 |
# Conflicts: # lib/modules/datasource/npm/get.ts
viceice
reviewed
May 19, 2023
| z.object({ | ||
| repository: PackageSource, | ||
| homepage: z.string().nullish().catch(null), | ||
| deprecated: z.string().nullish().catch('Unknown deprecation reason'), |
There was a problem hiding this comment.
catch will only be used if it's a wrong type that the expected string?
There was a problem hiding this comment.
I'm not sure if deprecated can be just true, so if it is, it will be converted to this default string
There was a problem hiding this comment.
BTW if it's false then it will be converted to this string too, but I don't worry about false as much as I worry about true.
There was a problem hiding this comment.
maybe better allow bool and transform to string if true and log debug if false?
|
🤔 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: