fix(manager/gradle): normalize version aliases in version catalogs #22470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes a regression introduced with #21820 by ensuring that all lookups of version refs (aliases) are performed on their normalized alias representations.
The regression happened because
version.ref
expected version aliases to occur with-
, instead of.
or_
. Since the corresponding version aliases themselves were not normalized, aliases with underscores could no longer be matched.The normalization scheme is aligned to the one used by Gradle. There was nothing wrong with replacing
_
by-
but since gradle replaces them by.
it seems reasonable to stay consistent with gradle here.Context
Some extra notes for occasional future reference:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Test repo: renovate-demo/22365#2