Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/gradle): normalize version aliases in version catalogs #22470

Merged
merged 1 commit into from May 29, 2023

Conversation

Churro
Copy link
Collaborator

@Churro Churro commented May 28, 2023

Changes

Fixes a regression introduced with #21820 by ensuring that all lookups of version refs (aliases) are performed on their normalized alias representations.

The regression happened because version.ref expected version aliases to occur with -, instead of . or _. Since the corresponding version aliases themselves were not normalized, aliases with underscores could no longer be matched.

The normalization scheme is aligned to the one used by Gradle. There was nothing wrong with replacing _ by - but since gradle replaces them by . it seems reasonable to stay consistent with gradle here.

Context

Some extra notes for occasional future reference:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Test repo: renovate-demo/22365#2

@Churro Churro changed the title fix(gradle): normalize aliases in version catalogs fix(gradle): normalize version aliases in version catalogs May 28, 2023
@Churro Churro changed the title fix(gradle): normalize version aliases in version catalogs fix(manager/gradle): normalize version aliases in version catalogs May 28, 2023
@rarkins rarkins added this pull request to the merge queue May 29, 2023
Merged via the queue into renovatebot:main with commit da6f2ed May 29, 2023
11 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 35.104.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants