feat(config): validate top-level options #28383
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
commented
Apr 13, 2024
There was a problem hiding this comment.
We need to check that each of these changes is correct and won't have unintended side effects.
viceice
reviewed
Apr 13, 2024
|
Also need to think how to handle |
|
For repo config options, anything valid in the top level is valid within onboardingConfig |
# Conflicts: # test/documentation.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds
.to allowableparentsfield and then adds this check to config validation.Context
Closes #28300
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: