Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mode=silent #28396

Merged
merged 6 commits into from May 6, 2024
Merged

feat: mode=silent #28396

merged 6 commits into from May 6, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 14, 2024

Changes

Adds a new config option "mode" with one new value: "silent".

Context

This is built with the Mend Renovate App in mind. I also planned to add "remediation" as another supported mode, but will do that later.

Closes #26724

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like that we have multiple settings for such a modes.

What prevents us to migrate dryRun to such a mode first?

I would see the current dryRun implementation as mode: dryRun and then we can have a option like dryRunMode that would make it easier to understand IMO.

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 14, 2024

I don't like that we have multiple settings for such a modes.

What prevents us to migrate dryRun to such a mode first?

I thought about it, but dryRun is tangental to this. dryRun means "make no changes, just tell me what you'd do". mode=silent and future mode=remediation both can make changes, and they are also both compatible with dryRun (e.g. you could test how mode=silent behaves if you supply checkedBranches as a param)

I would see the current dryRun implementation as mode: dryRun and then we can have a option like dryRunMode that would make it easier to understand IMO.

It's important to be able to combine the modes with dryRun, not make them exclusive like this. Plus you wouldn't save a config option either.

@secustor
Copy link
Collaborator

Hmm, than maybe should name it on-demand as you suggested in the issue. 🤔

As it is not really silent as it still uses checkedBranches.

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 14, 2024

It's silent unless told otherwise. On-demand isn't perfect either because can be mixed up with the concept of Dependency Dashboard Approval.

viceice
viceice previously approved these changes Apr 18, 2024
@rarkins rarkins marked this pull request as ready for review April 21, 2024 06:39
@rarkins
Copy link
Collaborator Author

rarkins commented Apr 21, 2024

Unfortunately this mode still clones for non-onboarded repos each time (even with repo cache enabled) but that's something we can improve later

Copy link
Contributor

@nabeelsaabna nabeelsaabna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Note: any notifications we want to the user to know about will only appear in the UI (like deprecating encrypted token in the repository config)

@rarkins rarkins added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 654c447 May 6, 2024
37 checks passed
@rarkins rarkins deleted the feat/silent-mode branch May 6, 2024 11:47
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.344.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support silent/full modes
5 participants