Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve merge confidence api base url variable doc #28532

Merged
merged 5 commits into from Apr 29, 2024

Conversation

mikaello
Copy link
Contributor

Changes

Improved the documentation for the env variable RENOVATE_X_MERGE_CONFIDENCE_API_BASE_URL. I have found it a bit confusing how this works, so I try to document this as I figure it out.

Context

See mend/renovate-ce-ee#488 (comment) for some context.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@HonkingGoose
Copy link
Collaborator

Please avoid force-pushing to the PR's branch. This resets the review progress, which makes it harder to see what changed.

We will squash merge this PR, and thus end with one clean commit on the main branch. So you do not need to keep your branch tidy. 🙂

@mikaello
Copy link
Contributor Author

Please avoid force-pushing to the PR's branch. This resets the review progress, which makes it harder to see what changed.

I see, I will remember this for future contributions.

I think there is a repo setting to disable the rebase button in PRs. Since it was not disabled I thought this was ok to select that option in the drop down menu for updating the branch.

@HonkingGoose
Copy link
Collaborator

Thank you for remembering it for future contributions! 😄

Hmm. I think that repository setting only limits the type of merges to the main branch. In short, it limits what merges a maintainer can select when merging a PR.

That repository setting does not seem to change which options the user sees to sync their fork of renovate.

docs/usage/self-hosted-experimental.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-experimental.md Show resolved Hide resolved
mikaello and others added 2 commits April 27, 2024 16:40
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins rarkins added this pull request to the merge queue Apr 29, 2024
Merged via the queue into renovatebot:main with commit b61eb4e Apr 29, 2024
37 checks passed
@HonkingGoose
Copy link
Collaborator

@mikaello thank you for improving the docs with your PR! ❤️🥳

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.327.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants