Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactor documentation tests for better navigation #28590

Merged
merged 3 commits into from Apr 29, 2024

Conversation

zharinov
Copy link
Collaborator

Changes

When the documentation tests fail, it takes some time to figure out which Markdown file to change.

This PR changes tests such that it will be more obvious from the Jest output.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov changed the title test: Refactor documentation tests for better navigation on failure test: Refactor documentation tests for better navigation Apr 22, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer async io, otherwise LGTM

test/documentation.spec.ts Show resolved Hide resolved
test/documentation.spec.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still prefer async even on tests 🤷‍♂️

@zharinov zharinov requested a review from rarkins April 26, 2024 16:09
@HonkingGoose HonkingGoose mentioned this pull request Apr 27, 2024
6 tasks
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, will refactor later to async 🙃

@viceice viceice added this pull request to the merge queue Apr 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 29, 2024
@rarkins rarkins enabled auto-merge April 29, 2024 13:28
@rarkins rarkins added this pull request to the merge queue Apr 29, 2024
Merged via the queue into renovatebot:main with commit 3663ba2 Apr 29, 2024
35 checks passed
@rarkins rarkins deleted the refactor/doc-test-describe-block branch April 29, 2024 13:34
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.328.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants