fix(autoReplace): Correct digest resolution when the replacementName and replacementVersion options are defined #28655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he replacementName option when it's running a replacement
rarkins
changed the title
viceice
requested changes
Apr 26, 2024
| // If the present contains the replacementName option and this update executes the replacement | ||
| // uses the correct lookupname based on the new replacementName, otherwise it keeps the origina one | ||
| if (update.updateType === 'replacement' && config.replacementName) { | ||
| getDigestConfig.lookupName = config.replacementName.substring(config.replacementName.indexOf("/") + 1); |
There was a problem hiding this comment.
this looks wrong to me. why the substring ?
It already has a test case for that part of the code. You can see it here I'm only improving one part of the code that fails when the replacementName option points to another image different from the original one. The test case didn't detect that error/unexpected result because it happens when the lookupUpdates function calls the getDigestConfig one with the wrong values and you are mocking that answer. I don't know if you are expecting something different. |
|
you can do expectations on the function call, so it's called with the right parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Context
Discussion #27728
Closes #20304
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: