Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency commander to v5.1.0 #6066

Merged
merged 3 commits into from Apr 28, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 28, 2020

Whitesource Renovate banner

This PR contains the following updates:

Package Update Type Change Sourcegraph
commander minor dependencies 5.0.0 -> 5.1.0 code search for "commander"

Release Notes

tj/commander.js

v5.1.0

Compare Source

Added
  • support for multiple command aliases, the first of which is shown in the auto-generated help ([#​531], [#​1236])
  • configuration support in addCommand() for hidden and isDefault ([#​1232])
Fixed
  • omit masked help flags from the displayed help ([#​645], [#​1247])
  • remove old short help flag when change help flags using helpOption ([#​1248])
Changed
  • remove use of arguments to improve auto-generated help in editors ([#​1235])
  • rename .command() configuration noHelp to hidden (but not remove old support) ([#​1232])
  • improvements to documentation
  • update dependencies
  • update tested versions of node
  • eliminate lint errors in TypeScript ([#​1208])

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled due to failing status checks.

♻️ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added the ready label Apr 28, 2020
renovate-approve[bot]
renovate-approve bot previously approved these changes Apr 28, 2020
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Apr 28, 2020
@viceice
Copy link
Member

viceice commented Apr 28, 2020

Naming conflict aliases is a new reserved option in commander v5.1

tj/commander.js#1236

@viceice viceice assigned viceice and unassigned rarkins Apr 28, 2020
@viceice viceice added in progress and removed ready labels Apr 28, 2020
@renovate
Copy link
Contributor Author

renovate bot commented Apr 28, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@viceice viceice requested a review from rarkins April 28, 2020 05:51
@viceice
Copy link
Member

viceice commented Apr 28, 2020

@rarkins Is it ok to have the comander changes here? Or should i extract to separate pr?

@rarkins
Copy link
Collaborator

rarkins commented Apr 28, 2020

I think it’s ok here but I wonder how we can fully test it. What do you think are the chances that any behaviour changes?

@viceice
Copy link
Member

viceice commented Apr 28, 2020

I think there is no behavior change, as all tests are passing (without change).

I only changed to official solution to avoid name clashes

@rarkins rarkins merged commit f102faf into master Apr 28, 2020
@rarkins rarkins deleted the renovate/commander-5.x branch April 28, 2020 06:49
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 19.219.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

viceice pushed a commit to zharinov/renovate that referenced this pull request Apr 29, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants