Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pr): fix broken markdown when version contains '|' #6235

Closed
wants to merge 7 commits into from
Closed

fix(pr): fix broken markdown when version contains '|' #6235

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
92ce4aa
fix(pr): fix broken markdown when version contains '|'
djcsdy May 14, 2020
6963a6c
Update updates-table.ts
rarkins Jul 11, 2020
c61e961
Merge branch 'master' into broken-pr-markdown
rarkins Jul 11, 2020
f0117d7
Merge branch 'master' into broken-pr-markdown
rarkins Jul 12, 2020
12fa021
Merge branch 'master' into broken-pr-markdown
viceice Jul 30, 2020
06d6a1b
Merge branch 'master' into broken-pr-markdown
viceice Aug 3, 2020
0e42cc5
Merge branch 'master' into broken-pr-markdown
viceice Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/workers/pr/body/updates-table.ts
View file
Open in desktop
Expand Up @@ -36,7 +36,7 @@ function getNonEmptyColumns(

export function getPrUpdatesTable(config: BranchConfig): string {
const tableDefinitions = getTableDefinition(config);
const tableValues = config.upgrades.map((upgrade) => {
const tableValues = config.upgrades.map(upgrade => {
const res: Record<string, string> = {};
for (const column of tableDefinitions) {
const { header, value } = column;
Expand All @@ -61,7 +61,9 @@ export function getPrUpdatesTable(config: BranchConfig): string {
for (const row of tableValues) {
let val = '|';
for (const column of tableColumns) {
val += ` ${row[column].replace(/^@/, '@&#8203;')} |`;
val += ' ';
val += row[column].replace(/^@/, '@&#8203;').replace(/\|/g, '\\|');
val += ' |';
}
val += '\n';
rows.push(val);
Expand Down