Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove lodash, add fast-deep-equal #6496

Merged
merged 4 commits into from Jun 26, 2020
Merged

refactor: remove lodash, add fast-deep-equal #6496

merged 4 commits into from Jun 26, 2020

Commits on Jun 26, 2020

  1. refactor: remove lodash 

    With the help of [You don't need lodash](https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore). Exceptions are:

- Replaced _.isEqual with [fast-deep-equal](https://github.com/epoberezkin/fast-deep-equal)
- Reimplemented sampleSize
- Reimplemented camelCase

Done as part of my investigation into jest memory leakage. Unfortunately it's brought in via a lot of our dependencies, but it helps a bit
    @JamieMagee
    JamieMagee committed Jun 26, 2020
    Copy the full SHA
    b5061ec View commit details
    Browse the repository at this point in the history

  2. test coverage

    @JamieMagee
    JamieMagee committed Jun 26, 2020
    Copy the full SHA
    740796e View commit details
    Browse the repository at this point in the history

  3. Remove lodash from datasource

    @JamieMagee
    JamieMagee committed Jun 26, 2020
    Copy the full SHA
    fa121fe View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into refactor/remove-lodash

    @JamieMagee
    JamieMagee committed Jun 26, 2020
    Copy the full SHA
    3e1a6b7 View commit details
    Browse the repository at this point in the history