feat(terraform-provider): Add secondary release repo

[secustor]

This PR adds releases.hashicorp.com as secondary repo for builds.

The primary source is still registry.terraform.io as it has more meta information e.g. source code repositories, changelogs, ...

Closes #5065

[rarkins]

Hi @secustor, can you refactor this a little before we focus on tests?

1. Move the existing registry logic out of getReleases() and into its own function, e.g. queryRegistry()
2. Use a single cache entry that covers both

e.g. the logic becomes

• if cached entry exists then return it
• look up registry
• if registry fails, look up releases
• cache result and return it

[secustor]

Rebased and updated to the new mocking setup.

Seems like the second nock scope is breaking the other unit tests.
Looks like a edge case which is not covered in the overloading.

[JamieMagee]

@secustor I fixed a couple of mocks you were missing. With the fallback logic you implemented, we need to mock both possible requests.

[rarkins]

@secustor are there any cases where results could be found in both registries and we'd prefer to combine results?

[secustor]

@JamieMagee Thx for your support.

@rarkins Not really the secondary repo contains only the available version and cpu architectures for the providers.

[rarkins]

Can you check out the recent commit I made which adds the concept registryStrategy = ‘hunt’? It simplifies the datasource implementations by pushing some logic into the index dispatcher.

Let me know if you’re interested to refactor as part of this PR or you don’t mind me refactoring it after.

[lgtm-com]

This pull request introduces 2 alerts when merging d8dfea2 into 7e51c90 - view on LGTM.com

new alerts:

• 2 for Incomplete URL substring sanitization

[lgtm-com]

This pull request introduces 2 alerts when merging cdf1516 into 7e51c90 - view on LGTM.com

new alerts:

• 2 for Incomplete URL substring sanitization

[secustor]

@rarkins I have refactored the changes to this new strategy system.

[renovate-release]

🎉 This PR is included in version 21.14.0 🎉

The release is available on:

• GitHub release
• 21.14.0

Your semantic-release bot 📦🚀