feat(internal): datasource registryStrategy

lib/datasource/__snapshots__/index.spec.ts.snap

@@ -22,3 +22,18 @@ Object {
   "sourceUrl": "https://github.com/nodejs/node",
 }
 `;
+
+exports[`datasource/index merges registries and returns success 1`] = `
+Object {
+  "releases": Array [
+    Object {
+      "version": "1.0.0",
+    },
+    Object {
+      "version": "1.1.0",
+    },
+  ],
+}
+`;
+
+exports[`datasource/index warns if multiple registryUrls for registryStrategy=first 1`] = `null`;

lib/datasource/common.ts

@@ -7,7 +7,9 @@ export interface Config {
   registryUrls?: string[];
 }
 
-export type DigestConfig = Config;
+export interface DigestConfig extends Config {
+  registryUrl?: string;
+}
 
 interface ReleasesConfigBase {
   compatibility?: Record<string, string>;
@@ -17,6 +19,7 @@ interface ReleasesConfigBase {
 
 export interface GetReleasesConfig extends ReleasesConfigBase {
   lookupName: string;
+  registryUrl?: string;
 }
 
 export interface GetPkgReleasesConfig extends ReleasesConfigBase {
@@ -65,6 +68,7 @@ export interface ReleaseResult {
   sourceUrl?: string;
   tags?: Record<string, string>;
   versions?: any;
+  registryUrl?: string;
 }
 
 export interface Datasource {
@@ -74,6 +78,7 @@ export interface Datasource {
   defaultRegistryUrls?: string[];
   appendRegistryUrls?: string[];
   defaultConfig?: object;
+  registryStrategy?: 'first' | 'hunt' | 'merge';
 }
 
 export class DatasourceError extends Error {

lib/datasource/docker/index.spec.ts

@@ -31,13 +31,16 @@ describe('api/docker', () => {
 
   describe('getRegistryRepository', () => {
     it('handles local registries', () => {
-      const res = docker.getRegistryRepository('registry:5000/org/package', []);
+      const res = docker.getRegistryRepository(
+        'registry:5000/org/package',
+        'https://index.docker.io'
+      );
       expect(res).toMatchSnapshot();
     });
     it('supports registryUrls', () => {
       const res = docker.getRegistryRepository(
         'my.local.registry/prefix/image',
-        ['https://my.local.registry/prefix']
+        'https://my.local.registry/prefix'
       );
       expect(res).toMatchSnapshot();
     });

lib/datasource/docker/index.ts

@@ -1,6 +1,5 @@
 import { OutgoingHttpHeaders } from 'http';
 import URL from 'url';
-import is from '@sindresorhus/is';
 import AWS from 'aws-sdk';
 import hasha from 'hasha';
 import parseLinkHeader from 'parse-link-header';
@@ -16,6 +15,8 @@ import { DatasourceError, GetReleasesConfig, ReleaseResult } from '../common';
 // TODO: replace www-authenticate with https://www.npmjs.com/package/auth-header ?
 
 export const id = 'docker';
+export const defaultRegistryUrls = ['https://index.docker.io'];
+export const registryStrategy = 'first';
 
 export const defaultConfig = {
   managerBranchPrefix: 'docker-',
@@ -57,10 +58,10 @@ export interface RegistryRepository {
 
 export function getRegistryRepository(
   lookupName: string,
-  registryUrls: string[]
+  registryUrl: string
 ): RegistryRepository {
-  if (is.nonEmptyArray(registryUrls)) {
-    const dockerRegistry = registryUrls[0]
+  if (registryUrl !== defaultRegistryUrls[0]) {
+    const dockerRegistry = registryUrl
       .replace('https://', '')
       .replace(/\/?$/, '/');
     if (lookupName.startsWith(dockerRegistry)) {
@@ -77,10 +78,10 @@ export function getRegistryRepository(
     split.shift();
   }
   let repository = split.join('/');
-  if (!registry && is.nonEmptyArray(registryUrls)) {
-    [registry] = registryUrls;
+  if (!registry) {
+    registry = registryUrl;
   }
-  if (!registry || registry === 'docker.io') {
+  if (registry === 'docker.io') {
     registry = 'index.docker.io';
   }
   if (!/^https?:\/\//.exec(registry)) {
@@ -327,12 +328,12 @@ async function getManifestResponse(
  *  - Return the digest as a string
  */
 export async function getDigest(
-  { registryUrls, lookupName }: GetReleasesConfig,
+  { registryUrl, lookupName }: GetReleasesConfig,
   newValue?: string
 ): Promise<string | null> {
   const { registry, repository } = getRegistryRepository(
     lookupName,
-    registryUrls
+    registryUrl
   );
   logger.debug(`getDigest(${registry}, ${repository}, ${newValue})`);
   const newTag = newValue || 'latest';
@@ -608,11 +609,11 @@ async function getLabels(
  */
 export async function getReleases({
   lookupName,
-  registryUrls,
+  registryUrl,
 }: GetReleasesConfig): Promise<ReleaseResult | null> {
   const { registry, repository } = getRegistryRepository(
     lookupName,
-    registryUrls
+    registryUrl
   );
   const tags = await getTags(registry, repository);
   if (!tags) {

lib/datasource/gitlab-tags/index.ts

@@ -1,5 +1,4 @@
 import URL from 'url';
-import is from '@sindresorhus/is';
 import { logger } from '../../logger';
 import * as globalCache from '../../util/cache/global';
 import { GitlabHttp } from '../../util/http/gitlab';
@@ -8,6 +7,8 @@ import { GetReleasesConfig, ReleaseResult } from '../common';
 const gitlabApi = new GitlabHttp();
 
 export const id = 'gitlab-tags';
+export const defaultRegistryUrls = ['https://gitlab.com'];
+export const registryStrategy = 'first';
 
 const cacheNamespace = 'datasource-gitlab';
 function getCacheKey(depHost: string, repo: string): string {
@@ -23,13 +24,9 @@ type GitlabTag = {
 };
 
 export async function getReleases({
-  registryUrls,
+  registryUrl: depHost,
   lookupName: repo,
 }: GetReleasesConfig): Promise<ReleaseResult | null> {
-  // Use registryUrls if present, otherwise default to publid gitlab.com
-  const depHost = is.nonEmptyArray(registryUrls)
-    ? registryUrls[0].replace(/\/$/, '')
-    : 'https://gitlab.com';
   let gitlabTags: GitlabTag[];
   const cachedResult = await globalCache.get<ReleaseResult>(
     cacheNamespace,
@@ -65,7 +62,7 @@ export async function getReleases({
   }
 
   const dependency: ReleaseResult = {
-    sourceUrl: `${depHost}/${repo}`,
+    sourceUrl: URL.resolve(depHost, repo),
     releases: null,
   };
   dependency.releases = gitlabTags.map(({ name, commit }) => ({