Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bundler): don't log error when Gemfile is invalid #6557

Merged
merged 1 commit into from Jun 22, 2020
Merged

fix(bundler): don't log error when Gemfile is invalid #6557

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/manager/bundler/extract.ts
View file
Open in desktop
Expand Up @@ -116,7 +116,7 @@ export async function extractPackageFile(
sourceLine = lines[lineNumber];
// istanbul ignore if
if (sourceLine === null || sourceLine === undefined) {
logger.error({ content, fileName }, 'Undefined sourceLine');
logger.info({ content, fileName }, 'Undefined sourceLine');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked info based on the guidelines in https://github.com/renovatebot/renovate/blob/8e97958dd17b3ec92926af10fc012bea66308d26/docs/development/design-decisions.md#logging-and-error-levels

sourceLine = 'end';
}
if (sourceLine !== 'end') {
Expand Down