Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Separate 'git' and 'fs' util modules #6665

Merged
merged 1 commit into from Jul 3, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/manager/bundler/artifacts.spec.ts
Expand Up @@ -20,7 +20,7 @@ jest.mock('fs-extra');
jest.mock('child_process');
jest.mock('../../../lib/util/exec/env');
jest.mock('../../../lib/datasource');
jest.mock('../../../lib/util/gitfs/fs');
jest.mock('../../../lib/util/fs');
jest.mock('../../../lib/util/host-rules');
jest.mock('./host-rules');

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/bundler/artifacts.ts
Expand Up @@ -10,7 +10,7 @@ import {
getSiblingFileName,
readLocalFile,
writeLocalFile,
} from '../../util/gitfs';
} from '../../util/fs';
import { isValid } from '../../versioning/ruby';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';
import {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/bundler/extract.spec.ts
Expand Up @@ -3,7 +3,7 @@ import { fs } from '../../../test/util';
import { isValid } from '../../versioning/ruby';
import { extractPackageFile } from './extract';

jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');

const railsGemfile = readFileSync(
'lib/manager/bundler/__fixtures__/Gemfile.rails',
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/bundler/extract.ts
@@ -1,7 +1,7 @@
import * as datasourceRubygems from '../../datasource/rubygems';
import { logger } from '../../logger';
import { SkipReason } from '../../types';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import { regEx } from '../../util/regex';
import { PackageDependency, PackageFile } from '../common';
import { extractLockFileEntries } from './locked-version';
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/bundler/utils.ts
@@ -1,6 +1,6 @@
import { join } from 'upath';
import { logger } from '../../logger';
import { ensureDir } from '../../util/gitfs';
import { ensureDir } from '../../util/fs';
import { UpdateArtifactsConfig } from '../common';

export async function getGemHome(
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/cargo/artifacts.ts
Expand Up @@ -5,7 +5,7 @@ import {
getSiblingFileName,
readLocalFile,
writeLocalFile,
} from '../../util/gitfs';
} from '../../util/fs';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';

export async function updateArtifacts({
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/cocoapods/artifacts.ts
Expand Up @@ -7,7 +7,7 @@ import {
getSiblingFileName,
readLocalFile,
writeLocalFile,
} from '../../util/gitfs';
} from '../../util/fs';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';
import { getCocoaPodsHome } from './utils';

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/cocoapods/utils.ts
@@ -1,6 +1,6 @@
import { join } from 'upath';
import { logger } from '../../logger';
import { ensureDir } from '../../util/gitfs';
import { ensureDir } from '../../util/fs';
import { UpdateArtifactsConfig } from '../common';

export async function getCocoaPodsHome(
Expand Down
4 changes: 2 additions & 2 deletions lib/manager/composer/artifacts.spec.ts
Expand Up @@ -6,12 +6,12 @@ import { setUtilConfig } from '../../util';
import { BinarySource } from '../../util/exec/common';
import * as docker from '../../util/exec/docker';
import * as _env from '../../util/exec/env';
import { StatusResult } from '../../util/gitfs';
import { StatusResult } from '../../util/git';
import * as composer from './artifacts';

jest.mock('child_process');
jest.mock('../../util/exec/env');
jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');
jest.mock('../../util/host-rules');

const hostRules = require('../../util/host-rules');
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/composer/artifacts.ts
Expand Up @@ -18,7 +18,7 @@ import {
getSiblingFileName,
readLocalFile,
writeLocalFile,
} from '../../util/gitfs';
} from '../../util/fs';
import * as hostRules from '../../util/host-rules';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/composer/extract.spec.ts
Expand Up @@ -2,7 +2,7 @@ import { readFileSync } from 'fs';
import { fs } from '../../../test/util';
import { extractPackageFile } from './extract';

jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');

const requirements1 = readFileSync(
'lib/manager/composer/__fixtures__/composer1.json',
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/composer/extract.ts
Expand Up @@ -3,7 +3,7 @@ import * as datasourceGitTags from '../../datasource/git-tags';
import * as datasourcePackagist from '../../datasource/packagist';
import { logger } from '../../logger';
import { SkipReason } from '../../types';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import { api as semverComposer } from '../../versioning/composer';
import { PackageDependency, PackageFile } from '../common';

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gitlabci-include/extract.ts
Expand Up @@ -3,7 +3,7 @@ import yaml from 'js-yaml';
import * as datasourceGitlabTags from '../../datasource/gitlab-tags';
import { logger } from '../../logger';
import { SkipReason } from '../../types';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import { ExtractConfig, PackageDependency, PackageFile } from '../common';
import * as gitlabci from '../gitlabci/extract';

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gomod/artifacts.spec.ts
Expand Up @@ -7,7 +7,7 @@ import { setUtilConfig } from '../../util';
import { BinarySource } from '../../util/exec/common';
import * as docker from '../../util/exec/docker';
import * as _env from '../../util/exec/env';
import { StatusResult } from '../../util/gitfs';
import { StatusResult } from '../../util/git';
import * as _hostRules from '../../util/host-rules';
import * as gomod from './artifacts';

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gomod/artifacts.ts
Expand Up @@ -6,7 +6,7 @@ import { logger } from '../../logger';
import { platform } from '../../platform';
import { ExecOptions, exec } from '../../util/exec';
import { BinarySource } from '../../util/exec/common';
import { readLocalFile, writeLocalFile } from '../../util/gitfs';
import { readLocalFile, writeLocalFile } from '../../util/fs';
import { find } from '../../util/host-rules';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';

Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gradle-wrapper/artifacts.spec.ts
Expand Up @@ -19,7 +19,7 @@ import { resetPrefetchedImages } from '../../util/exec/docker';
import * as dcUpdate from '.';

jest.mock('child_process');
jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');
jest.mock('../../util/exec/env');

const exec: jest.Mock<typeof _exec> = _exec as any;
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gradle-wrapper/artifacts.ts
Expand Up @@ -4,7 +4,7 @@ import Git from 'simple-git/promise';
import { logger } from '../../logger';
import { platform } from '../../platform';
import { ExecOptions, exec } from '../../util/exec';
import { readLocalFile, writeLocalFile } from '../../util/gitfs';
import { readLocalFile, writeLocalFile } from '../../util/fs';
import { Http } from '../../util/http';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';
import { gradleWrapperFileName, prepareGradleCommand } from '../gradle/index';
Expand Down
6 changes: 3 additions & 3 deletions lib/manager/gradle/index.spec.ts
Expand Up @@ -9,7 +9,7 @@ import * as _util from '../../util';
import { BinarySource } from '../../util/exec/common';
import * as _docker from '../../util/exec/docker';
import * as _env from '../../util/exec/env';
import * as _fs from '../../util/gitfs/fs';
import * as _fs from '../../util/fs';
import { ExtractConfig } from '../common';
import { ifSystemSupportsGradle } from './__testutil__/gradle';
import { GRADLE_DEPENDENCY_REPORT_FILENAME } from './gradle-updates-report';
Expand Down Expand Up @@ -44,11 +44,11 @@ async function setupMocks() {

jest.mock('child_process');
jest.mock('../../util/exec/env');
jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');
jest.mock('os');

const os: jest.Mocked<typeof _os> = require('os');
const fs: jest.Mocked<typeof _fs> = require('../../util/gitfs/fs');
const fs: jest.Mocked<typeof _fs> = require('../../util/fs');
const env: jest.Mocked<typeof _env> = require('../../util/exec/env');
const exec: jest.Mock<typeof _exec> = require('child_process').exec;
const util: jest.Mocked<typeof _util> = require('../../util');
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/gradle/index.ts
Expand Up @@ -8,7 +8,7 @@ import { logger } from '../../logger';
import { ExternalHostError } from '../../types/errors/external-host-error';
import { ExecOptions, exec } from '../../util/exec';
import { BinarySource } from '../../util/exec/common';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import * as gradleVersioning from '../../versioning/gradle';
import {
ExtractConfig,
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/helm-requirements/extract.spec.ts
@@ -1,7 +1,7 @@
import { fs } from '../../../test/util';
import { extractPackageFile } from './extract';

jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');

describe('lib/manager/helm-requirements/extract', () => {
describe('extractPackageFile()', () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/helm-requirements/extract.ts
Expand Up @@ -3,7 +3,7 @@ import yaml from 'js-yaml';
import * as datasourceHelm from '../../datasource/helm';
import { logger } from '../../logger';
import { SkipReason } from '../../types';
import { getSiblingFileName, readLocalFile } from '../../util/gitfs';
import { getSiblingFileName, readLocalFile } from '../../util/fs';
import { ExtractConfig, PackageDependency, PackageFile } from '../common';

export async function extractPackageFile(
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/maven/extract.ts
Expand Up @@ -5,7 +5,7 @@ import * as datasourceMaven from '../../datasource/maven';
import { MAVEN_REPO } from '../../datasource/maven/common';
import { logger } from '../../logger';
import { SkipReason } from '../../types';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import { ExtractConfig, PackageDependency, PackageFile } from '../common';

export function parsePom(raw: string): XmlDocument | null {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/maven/index.spec.ts
Expand Up @@ -4,7 +4,7 @@ import { PackageDependency, PackageFile } from '../common';
import { extractPackage, resolveParents } from './extract';
import { extractAllPackageFiles, updateDependency } from './index';

jest.mock('../../util/gitfs/fs');
jest.mock('../../util/fs');

const pomContent = readFileSync(
'lib/manager/maven/__fixtures__/simple.pom.xml',
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/mix/artifacts.ts
Expand Up @@ -4,7 +4,7 @@ import upath from 'upath';
import { logger } from '../../logger';
import { exec } from '../../util/exec';
import { BinarySource } from '../../util/exec/common';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';

export async function updateArtifacts({
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/extract/index.spec.ts
@@ -1,7 +1,7 @@
import { readFileSync } from 'fs';
import path from 'path';
import { getConfig } from '../../../config/defaults';
import * as _fs from '../../../util/gitfs/fs';
import * as _fs from '../../../util/fs';
import * as npmExtract from '.';

const fs: any = _fs;
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/extract/index.ts
Expand Up @@ -10,7 +10,7 @@ import {
deleteLocalFile,
getSiblingFileName,
readLocalFile,
} from '../../../util/gitfs';
} from '../../../util/fs';
import * as nodeVersioning from '../../../versioning/node';
import { isValid, isVersion } from '../../../versioning/npm';
import {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/extract/npm.spec.ts
Expand Up @@ -2,7 +2,7 @@ import { readFileSync } from 'fs';
import { fs } from '../../../../test/util';
import { getNpmLock } from './npm';

jest.mock('../../../util/gitfs/fs');
jest.mock('../../../util/fs');

describe('manager/npm/extract/npm', () => {
describe('.getNpmLock()', () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/extract/npm.ts
@@ -1,5 +1,5 @@
import { logger } from '../../../logger';
import { readLocalFile } from '../../../util/gitfs';
import { readLocalFile } from '../../../util/fs';
import { LockFileEntry } from './common';

export async function getNpmLock(
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/extract/yarn.spec.ts
Expand Up @@ -2,7 +2,7 @@ import { readFileSync } from 'fs';
import { fs } from '../../../../test/util';
import { getYarnLock } from './yarn';

jest.mock('../../../util/gitfs/fs');
jest.mock('../../../util/fs');

describe('manager/npm/extract/yarn', () => {
describe('.getYarnLock()', () => {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/extract/yarn.ts
@@ -1,6 +1,6 @@
import { parse } from '@yarnpkg/lockfile';
import { logger } from '../../../logger';
import { readLocalFile } from '../../../util/gitfs';
import { readLocalFile } from '../../../util/fs';
import { LockFileEntry } from './common';

export type YarnLock = Record<string, string>;
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/post-update/index.ts
Expand Up @@ -8,7 +8,7 @@ import { logger } from '../../../logger';
import { platform } from '../../../platform';
import { ExternalHostError } from '../../../types/errors/external-host-error';
import { getChildProcessEnv } from '../../../util/exec/env';
import { deleteLocalFile } from '../../../util/gitfs';
import { deleteLocalFile } from '../../../util/fs';
import * as hostRules from '../../../util/host-rules';
import { PackageFile, PostUpdateConfig, Upgrade } from '../../common';
import * as lerna from './lerna';
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/post-update/node-version.spec.ts
@@ -1,7 +1,7 @@
import { fs } from '../../../../test/util';
import { getNodeConstraint } from './node-version';

jest.mock('../../../util/gitfs/fs');
jest.mock('../../../util/fs');

describe('getNodeConstraint', () => {
const config = {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/npm/post-update/node-version.ts
@@ -1,6 +1,6 @@
import { validRange } from 'semver';
import { logger } from '../../../logger';
import { getSiblingFileName, readLocalFile } from '../../../util/gitfs';
import { getSiblingFileName, readLocalFile } from '../../../util/fs';
import { PostUpdateConfig } from '../../common';

async function getNodeFile(filename: string): Promise<string> | null {
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/pip_requirements/artifacts.ts
@@ -1,7 +1,7 @@
import is from '@sindresorhus/is';
import { logger } from '../../logger';
import { ExecOptions, exec } from '../../util/exec';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import { UpdateArtifact, UpdateArtifactsResult } from '../common';

export async function updateArtifacts({
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/pipenv/artifacts.spec.ts
Expand Up @@ -7,7 +7,7 @@ import { setUtilConfig } from '../../util';
import { BinarySource } from '../../util/exec/common';
import * as docker from '../../util/exec/docker';
import * as _env from '../../util/exec/env';
import { StatusResult } from '../../util/gitfs';
import { StatusResult } from '../../util/git';
import * as pipenv from './artifacts';

jest.mock('fs-extra');
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/pipenv/artifacts.ts
Expand Up @@ -3,7 +3,7 @@ import { join } from 'upath';
import { logger } from '../../logger';
import { platform } from '../../platform';
import { ExecOptions, exec } from '../../util/exec';
import { readLocalFile } from '../../util/gitfs';
import { readLocalFile } from '../../util/fs';
import {
UpdateArtifact,
UpdateArtifactsConfig,
Expand Down
2 changes: 1 addition & 1 deletion lib/manager/poetry/artifacts.ts
Expand Up @@ -8,7 +8,7 @@ import {
getSiblingFileName,
readLocalFile,
writeLocalFile,
} from '../../util/gitfs';
} from '../../util/fs';
import {
UpdateArtifact,
UpdateArtifactsConfig,
Expand Down
6 changes: 3 additions & 3 deletions lib/platform/azure/index.spec.ts
@@ -1,7 +1,7 @@
import is from '@sindresorhus/is';
import { REPOSITORY_DISABLED } from '../../constants/error-messages';
import { BranchStatus } from '../../types';
import * as _git from '../../util/gitfs/git';
import * as _git from '../../util/git';
import * as _hostRules from '../../util/host-rules';
import { Platform, RepoParams } from '../common';

Expand All @@ -16,14 +16,14 @@ describe('platform/azure', () => {
jest.resetModules();
jest.mock('./azure-got-wrapper');
jest.mock('./azure-helper');
jest.mock('../../util/gitfs/git');
jest.mock('../../util/git');
jest.mock('../../util/host-rules');
hostRules = require('../../util/host-rules');
require('../../util/sanitize').sanitize = jest.fn((input) => input);
azure = await import('.');
azureApi = require('./azure-got-wrapper');
azureHelper = require('./azure-helper');
git = require('../../util/gitfs/git');
git = require('../../util/git');
git.branchExists.mockResolvedValue(true);
git.isBranchStale.mockResolvedValue(false);
hostRules.find.mockReturnValue({
Expand Down