New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace those 'fs-extra' functions in which we can be sure #6666
refactor: Replace those 'fs-extra' functions in which we can be sure #6666
Conversation
@@ -65,7 +65,7 @@ export async function updateArtifacts({ | |||
await writeLocalFile(packageFileName, newPackageFileContent); | |||
const cmd: string[] = []; | |||
if (config.isLockFileMaintenance) { | |||
await fs.remove(lockFileName); | |||
await deleteLocalFile(lockFileName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, not sure about this one though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be right. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -65,7 +65,7 @@ export async function updateArtifacts({ | |||
await writeLocalFile(packageFileName, newPackageFileContent); | |||
const cmd: string[] = []; | |||
if (config.isLockFileMaintenance) { | |||
await fs.remove(lockFileName); | |||
await deleteLocalFile(lockFileName); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be right. 🤔
🎉 This PR is included in version 21.22.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Ref #6617