Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rubygems): fallback to info when version fails #7323

Merged
merged 14 commits into from Sep 22, 2020
Merged

feat(rubygems): fallback to info when version fails #7323

Changes from 5 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
7686839
feat: fallback to info when version fails
henrysachs Sep 18, 2020
cca7aa9
fix: catch error when request errors
henrysachs Sep 18, 2020
ab58b0c
fix: revert try catch
henrysachs Sep 18, 2020
450eda1
build: add yarn lock
henrysachs Sep 18, 2020
d88e287
Merge branch 'master' into feature/fallback-to-info
rarkins Sep 21, 2020
52f6ef2
fix: catch the error from the failed request
henrysachs Sep 21, 2020
cc1f436
fix: add errorhandling
henrysachs Sep 21, 2020
a67a545
chore: add henry sachs to contributors
henrysachs Sep 21, 2020
6e0506d
fix: only throw when its something else than 400 or 404
henrysachs Sep 21, 2020
66def28
Update lib/datasource/rubygems/get.ts
henrysachs Sep 21, 2020
95cf3ea
test: add test for fallback feature
henrysachs Sep 22, 2020
650105d
test: add test for unknow error case
henrysachs Sep 22, 2020
7307401
fix: eslint fixes and removed unused parameters
henrysachs Sep 22, 2020
12c6c67
Merge branch 'master' into feature/fallback-to-info
rarkins Sep 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 14 additions & 1 deletion lib/datasource/rubygems/get.ts
View file
Open in desktop
Expand Up @@ -52,7 +52,7 @@ export async function getDependency(

const versions = (await fetch(dependency, registry, VERSIONS_PATH)) || [];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this request throw ? If so then everything below it is not executed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought it doesnt because of the || if not than i can add a try catch around it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to be sure a try catch would look like the following right? I can implement this if you want me to.

let versions = []
try {
 versions = await fetch(dependency, registry, VERSIONS_PATH);
} catch {
// all of my code
}


const releases = versions.map(
let releases = versions.map(
({
number: version,
platform: rubyPlatform,
Expand All @@ -68,6 +68,19 @@ export async function getDependency(
})
);

if (versions.length === 0 && info.version) {
logger.warn('falling back to the version from the info endpoint');
releases = [
{
version: info.version,
rubyPlatform: info.platform,
releaseTimestamp: null,
rubyVersion: null,
rubygemsVersion: '\u003e= 0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of this value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was the default value from the versions endpoint its basically >= 0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we can remove it I just wanted to match the signature from the "default" case

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, remove it

},
];
}

return {
releases,
homepage: info.homepage_uri,
Expand Down