Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecated logLevel option #8293

Merged
merged 5 commits into from Jan 14, 2021
Merged

feat: deprecated logLevel option #8293

merged 5 commits into from Jan 14, 2021

Conversation

viceice
Copy link
Member

@viceice viceice commented Jan 14, 2021

Changes:

Deprecate logLevel config option.

Context:

#8291

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge (squash) January 14, 2021 11:36
@rarkins rarkins merged commit 76ada5e into master Jan 14, 2021
@rarkins rarkins deleted the feat/deprecate-log-level branch January 14, 2021 12:11
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

rarkins added a commit that referenced this pull request Jan 14, 2021
@rarkins rarkins restored the feat/deprecate-log-level branch January 14, 2021 14:13
@rarkins
Copy link
Collaborator

rarkins commented Jan 14, 2021

@viceice I discovered that this warns even if you do define LOG_LEVEL=debug in env only, so I have reverted it. Do you want to create a new PR out of the restored branch? I think we need to check specifically in file and CLI config only.

@viceice
Copy link
Member Author

viceice commented Jan 14, 2021

Sure, I'll check now why it warns

@viceice
Copy link
Member Author

viceice commented Jan 14, 2021

ha, forgot to update this:

env: 'LOG_LEVEL',

🤦‍♂️

@viceice viceice mentioned this pull request Jan 14, 2021
5 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants