Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ignore unavailable users #9406

Merged
merged 32 commits into from Apr 22, 2021
Merged
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
9a0cb6b
feat: ignore unavailable users
fgreinacher Apr 5, 2021
42f282d
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 5, 2021
c5817da
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 14, 2021
f7a2207
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 15, 2021
d044ceb
filter users via platform
fgreinacher Apr 15, 2021
9c59d35
add config option
fgreinacher Apr 15, 2021
9271fe7
implement filterUnavailableUsers for GitLab
fgreinacher Apr 15, 2021
ac8cac8
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 18, 2021
b0431ba
Update docs/usage/configuration-options.md
fgreinacher Apr 18, 2021
12af97a
Rename filterUnavailableUsers to filterOutUnavailableUsers
fgreinacher Apr 18, 2021
8b57588
Merge branch 'feat/filter-unavailable-users' of https://github.com/fg…
fgreinacher Apr 18, 2021
3fb2649
Update docs/usage/configuration-options.md
fgreinacher Apr 19, 2021
e9b23f2
Move isUserBusy and related types to appropriate files
fgreinacher Apr 19, 2021
9c1a659
Merge branch 'feat/filter-unavailable-users' of https://github.com/fg…
fgreinacher Apr 19, 2021
d1a1c7a
Update lib/platform/gitlab/http.ts
viceice Apr 19, 2021
013691e
Merge branch 'master' into feat/filter-unavailable-users
viceice Apr 19, 2021
e1edc49
Warn when enabling unsupported option
fgreinacher Apr 19, 2021
35bb528
Merge branch 'feat/filter-unavailable-users' of https://github.com/fg…
fgreinacher Apr 19, 2021
100b97c
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 21, 2021
9c19517
Rename filterOutUnavailableUsers to filterUnavailableUsers
fgreinacher Apr 21, 2021
c3c601c
Merge branch 'feat/filter-unavailable-users' of https://github.com/fg…
fgreinacher Apr 21, 2021
cbd5430
Assert warnings
fgreinacher Apr 21, 2021
6881ce4
Update snapshots to accomodate for http layer changes
fgreinacher Apr 21, 2021
3af5ff6
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 21, 2021
e641e7c
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 21, 2021
167dbeb
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 22, 2021
6962a6f
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 22, 2021
544ca07
Merge branch 'master' into feat/filter-unavailable-users
fgreinacher Apr 22, 2021
f25cd46
Merge branch 'master' into feat/filter-unavailable-users
viceice Apr 22, 2021
6d4aa14
Apply suggestions from code review
fgreinacher Apr 22, 2021
f25f0a6
fix assertion
fgreinacher Apr 22, 2021
591c84b
Merge branch 'main' into feat/filter-unavailable-users
fgreinacher Apr 22, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/workers/pr/index.ts
Expand Up @@ -37,6 +37,11 @@ async function addCodeOwners(
return [...new Set(assigneesOrReviewers.concat(await codeOwnersForPr(pr)))];
}

function filterUnavailableUsers(users: string[]): string[] {
return users;
// TODO: Delegate filtering logic to platform.
fgreinacher marked this conversation as resolved.
Show resolved Hide resolved
}

export async function addAssigneesReviewers(
config: RenovateConfig,
pr: Pr
Expand All @@ -45,6 +50,7 @@ export async function addAssigneesReviewers(
if (config.assigneesFromCodeOwners) {
assignees = await addCodeOwners(assignees, pr);
}
assignees = filterUnavailableUsers(assignees);
fgreinacher marked this conversation as resolved.
Show resolved Hide resolved
if (assignees.length > 0) {
try {
assignees = assignees.map(noLeadingAtSymbol);
Expand Down Expand Up @@ -74,6 +80,7 @@ export async function addAssigneesReviewers(
if (config.additionalReviewers.length > 0) {
reviewers = reviewers.concat(config.additionalReviewers);
}
reviewers = filterUnavailableUsers(reviewers);
if (reviewers.length > 0) {
try {
reviewers = [...new Set(reviewers.map(noLeadingAtSymbol))];
Expand Down