New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cake): quoted references #9692
Conversation
I modified parser and lexer of the Cake manager to recognize references that are fully set in quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @zharinov can you check the lexer changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should simplify it.
Even if unrelated, please move const lexer to module scope for perfomance and memory reasons. renovate/lib/manager/cake/index.ts Line 52 in ed0605e
@rarkins I think we (re)create too many moo lexers, which can be another memory and performance issue. So @zharinov can you open a pr to move those to module scope, so the lexers are created once? |
Does anything need to be changed for this PR to be accepted though? |
See my second review 😉 |
@viceice I'll move all lexers to global scope in separate PR today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zharinov What do you think about my suggestions to use a moo transform instead of triming the quotes later? |
use a moo transform instead of an additional if
@viceice I implemented the suggested change from |
@rarkins Backport to v24? |
🎉 This PR is included in version 25.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Changes:
I modified parser and lexer of the Cake manager to
recognize references that are fully set in quotes.
Context:
Closes #9691
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: