Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(maven): lookup parent homepage/scm information from pom #9722
feat(maven): lookup parent homepage/scm information from pom #9722
Changes from 4 commits
6d07cf2
7f854ef
8b3f682
9f38ac7
74f2301
fe9dce1
3d8b9d1
0081ff0
14e036a
bb71dc0
5bb9852
6ea8020
3d54176
50505af
d257e11
fb6cde8
6655340
317d168
47901c5
0d5c9b9
8c202e4
a277607
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @twendelmuth, thanks for merging my changes. Finally, we need to limit the recursion depth and test it on self-referencing pomfile. I would limit to 5, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5 sounds reasonable - I could see certain projects might go a bit deeper than that but it's a good starting point imo.
Regarding the self-reference:
I guess you're referring to circular dependencies like POM1 -> POM2 -> POM1? A POM is not allowed to be it's own parent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was a bit lazy for creating circle with 2 participants 🙃