Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argocd): implement manager #9771
feat(argocd): implement manager #9771
Changes from 7 commits
a763ff3
dfa9874
9eb1ca9
f428bb6
4e7e97c
7b3401b
e892dae
c5fe16f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, so we can save parsing phase if we know this is no argocd document. 👍
@rarkins I think we can enable it by default for all yaml files as this regex will ignore files which do not have argocd content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main concern is that repos may have hundreds of YAML files while only a very small fraction would be argo or even use argo.
Is there any naming convention which would cover maybe 80%+ of the files e.g.
/argo.*\.yaml$/i
?If so then I'd prefer that as the default. But if not, it could be ok to default to all
.yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, there aren't such conventions.
Basically this is updating Kubernetes manifests which contain ArgoCD CR manifests. Because of that fact every
.yaml
could contain an ArgoCD manifest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, let's see how it goes then. I think we may read detected files into memory in parallel, so it could increase memory use by a lot if there are large YAML files.