New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: separate update generation #9788
Conversation
@@ -170,12 +170,10 @@ Object { | |||
|
|||
exports[`workers/repository/process/lookup/index .lookupUpdates() handles git submodule update 1`] = ` | |||
Object { | |||
"currentVersion": undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check this isn't a mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because you moved the versioning.valueToVersion
call to inside the isValid
condition and git submodules don't have a current value.
if (isValid) { |
@JamieMagee Maybe we should pass the tracking branch as current value and add a git versioning, which allows branches / tags as version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we call valueToVersion
now only on valid currentValue
. Maybe we should mark this pr as feature, as it causes a bahavior change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More detailed check tomorrow
@@ -170,12 +170,10 @@ Object { | |||
|
|||
exports[`workers/repository/process/lookup/index .lookupUpdates() handles git submodule update 1`] = ` | |||
Object { | |||
"currentVersion": undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because you moved the versioning.valueToVersion
call to inside the isValid
condition and git submodules don't have a current value.
if (isValid) { |
@JamieMagee Maybe we should pass the tracking branch as current value and add a git versioning, which allows branches / tags as version?
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but see comment
@@ -170,12 +170,10 @@ Object { | |||
|
|||
exports[`workers/repository/process/lookup/index .lookupUpdates() handles git submodule update 1`] = ` | |||
Object { | |||
"currentVersion": undefined, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we call valueToVersion
now only on valid currentValue
. Maybe we should mark this pr as feature, as it causes a bahavior change here.
I've reverted that change so that snapshots remain the same. Will make such a change in a different PR if it's necessary. |
🎉 This PR is included in version 25.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Refactors update generation into a separate file.
Context:
Improvements before an upcoming feature.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: