Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: setup tokenization #265

Merged
merged 5 commits into from
Jan 19, 2023
Merged

Conversation

HonkingGoose
Copy link
Collaborator

Changes:

Context:

I first started by copy/pasting the example regex from the Material for MkDocs manual, and then @TWiStErRob had a better regex for us to try.

Read the Material for MkDocs about separator.

Helps with issue #264.

@HonkingGoose HonkingGoose marked this pull request as ready for review January 18, 2023 15:26
Copy link
Collaborator Author

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the search in my Codespaces preview. Search work fine as far as I can tell. I have not seen anything that's obviously broken.

I'll let the maintainers review and eventually merge this. 😉

@rarkins rarkins enabled auto-merge (squash) January 19, 2023 05:57
@rarkins rarkins merged commit 89361d1 into renovatebot:main Jan 19, 2023
@rarkins
Copy link
Contributor

rarkins commented Jan 19, 2023

How can we verify it's working as intended?

@TWiStErRob
Copy link

TWiStErRob commented Jan 19, 2023

@rarkins expand the thread above, there are screenshots from before merge (there may be some in the issue too), if you get better results, it's working :)

Also in general just search for random things you can think of and if you can find it, it works.

@HonkingGoose HonkingGoose deleted the search-tokens branch January 19, 2023 08:54
@rarkins
Copy link
Contributor

rarkins commented Jan 19, 2023

I happened to use the docs site for regular reasons and wonder if this update has broken some important search capabilities by tokenizing too much? For example:

image

image

image

rarkins added a commit that referenced this pull request Jan 19, 2023
@rarkins rarkins mentioned this pull request Jan 19, 2023
@TWiStErRob
Copy link

Hmm, it looks like it needs to be able to split on something:

image

image

image

In your search postu is a word, but that word doesn't exist in the indexes.

@rarkins
Copy link
Contributor

rarkins commented Jan 19, 2023

We might live with that if it weren't for the fact that an exact match returns no result!

@TWiStErRob
Copy link

TWiStErRob commented Jan 19, 2023

Before this change, exact (case sensitively!) returned no result either: #265 (comment)
Right now, only "exact lowercase" match is empty.
So I think you want to disable that part only, see #264 (comment)

@rarkins
Copy link
Contributor

rarkins commented Jan 19, 2023

Oh, I didn't realize that! Guess I never tried it before, or that I only needed to type part of the word before clicking

@rarkins
Copy link
Contributor

rarkins commented Jan 19, 2023

I'll close my PR for now

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants