Fix rollup.js issues in nextjs-apollo-config #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p dependencies" This reverts commit e7f8b3b.
trm217
force-pushed
the
fix/rollup-heroku-issues
branch
from
605e79e
to
ba3e68e
Compare
|
TS seems to work fine in editors after moving to compiling only with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #159 which removed the rollup setup from
nextjs-apollo-config.It seems the problems where caused by the latest patch release of
@rollup/typescript-plugin(v8.3.4) which was released at the end of last week (the following changes seemed to cause the issue). After locking the version of the rollup-plugin the issue we saw when deploying to staging, stopped.Besides that the TS-config now the defines the source folder explicitly & the rollup-plugin order was changed to run the commonjs-plugin before the typescript-plugin (which should've been the case all along).