Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in README.md #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

franklsm1
Copy link

remove bad parameter in catch block

remove bad parameter in catch block
@coveralls
Copy link

coveralls commented Nov 22, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling b5e33ec on franklsm1:franklsm1-patch-1 into 1389cf7 on request:master.

@analog-nico
Copy link
Member

Quick question because errors.TransformError is there by design:

  • Do you think it is too confusing to use this Bluebird specific error filter here and we should remove it for this reason?
  • Or is the code not working actually?

@franklsm1
Copy link
Author

@analog-nico It actually works just confusing was all, but maybe that was just my co-worker and I trying to figure it out. For an example it just seemed easier to to stick with the standard catch block. Yes bluebird promises are used by rp, but normal promises do not allow those filters.

It was just a suggestion, and can be rejected if you see otherwise :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants