Merge pull request #1474 from erykwalder/master

Require Colon in Basic Auth
request · Mar 16, 2015 · 1774b03 · 1774b03
2 parents 41984f9 + 1080332
commit 1774b03
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/auth.js b/lib/auth.js
@@ -26,7 +26,7 @@ Auth.prototype.basic = function (user, pass, sendImmediately) {
   self.user = user
   self.pass = pass
   self.hasAuth = true
-  var header = typeof pass !== 'undefined' ? user + ':' + pass : user
+  var header = user + ':' + (pass || '')
   if (sendImmediately || typeof sendImmediately === 'undefined') {
     var authHeader = 'Basic ' + toBase64(header)
     self.sentAuth = true

diff --git a/tests/test-basic-auth.js b/tests/test-basic-auth.js
@@ -22,8 +22,6 @@ tape('setup', function(t) {
         ok = true
       } else if ( req.headers.authorization === 'Basic ' + new Buffer(':pass').toString('base64')) {
         ok = true
-      } else if ( req.headers.authorization === 'Basic ' + new Buffer('user').toString('base64')) {
-        ok = true
       } else {
         // Bad auth header, don't send back WWW-Authenticate header
         ok = false