Merge pull request #1956 from jongyoonlee/master

Check form-data content-length value before setting up the header

request.js

@@ -579,7 +579,7 @@ Request.prototype.init = function (options) {
       // Before ending the request, we had to compute the length of the whole form, asyncly
       self.setHeader(self._form.getHeaders(), true)
       self._form.getLength(function (err, length) {
-        if (!err) {
+        if (!err && !isNaN(length)) {
           self.setHeader('content-length', length)
         }
         end()

tests/test-form-data-error.js

@@ -27,8 +27,46 @@ tape('re-emit formData errors', function(t) {
   }).form().append('field', ['value1', 'value2'])
 })
 
+tape('omit content-length header if the value is set to NaN', function(t) {
+
+  // returns chunked HTTP response which is streamed to the 2nd HTTP request in the form data
+  s.on('/chunky', server.createChunkResponse(
+    ['some string',
+      'some other string'
+    ]))
+
+  // accepts form data request
+  s.on('/stream', function(req, resp) {
+    req.on('data', function(chunk) {
+      // consume the request body
+    })
+    req.on('end', function() {
+      resp.writeHead(200)
+      resp.end()
+    })
+  })
+
+  var sendStreamRequest = function(stream) {
+    request.post({
+      uri: s.url + '/stream',
+      formData: {
+        param: stream
+      }
+    }, function(err, res) {
+      t.error(err, 'request failed')
+      t.end()
+    })
+  }
+
+  request.get({
+    uri: s.url + '/chunky',
+  }).on('response', function(res) {
+    sendStreamRequest(res)
+  })
+})
+
 tape('cleanup', function(t) {
   s.close(function() {
     t.end()
   })
-})
+})