Skip to content

Commit

Permalink
Merge pull request #2175 from simov/delete-method
Browse files Browse the repository at this point in the history
Add 'delete' alias for the 'del' API method
  • Loading branch information
simov committed Apr 16, 2016
2 parents 00eaf55 + 865e981 commit 2ef974a
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 5 deletions.
3 changes: 2 additions & 1 deletion README.md
Expand Up @@ -889,12 +889,13 @@ Same as `request()`, but defaults to `method: "HEAD"`.
request.head(url)
```

### request.del
### request.del / request.delete

Same as `request()`, but defaults to `method: "DELETE"`.

```js
request.del(url)
request.delete(url)
```

### request.get
Expand Down
9 changes: 5 additions & 4 deletions index.js
Expand Up @@ -56,7 +56,7 @@ function request (uri, options, callback) {
}

function verbFunc (verb) {
var method = verb === 'del' ? 'DELETE' : verb.toUpperCase()
var method = verb.toUpperCase()
return function (uri, options, callback) {
var params = initParams(uri, options, callback)
params.method = method
Expand All @@ -70,7 +70,8 @@ request.head = verbFunc('head')
request.post = verbFunc('post')
request.put = verbFunc('put')
request.patch = verbFunc('patch')
request.del = verbFunc('del')
request.del = verbFunc('delete')
request['delete'] = verbFunc('delete')

request.jar = function (store) {
return cookies.jar(store)
Expand All @@ -91,7 +92,7 @@ function wrapRequestMethod (method, options, requester, verb) {
target.pool = params.pool || options.pool

if (verb) {
target.method = (verb === 'del' ? 'DELETE' : verb.toUpperCase())
target.method = verb.toUpperCase()
}

if (isFunction(requester)) {
Expand All @@ -114,7 +115,7 @@ request.defaults = function (options, requester) {

var defaults = wrapRequestMethod(self, options, requester)

var verbs = ['get', 'head', 'post', 'put', 'patch', 'del']
var verbs = ['get', 'head', 'post', 'put', 'patch', 'del', 'delete']
verbs.forEach(function(verb) {
defaults[verb] = wrapRequestMethod(self[verb], options, requester, verb)
})
Expand Down
11 changes: 11 additions & 0 deletions tests/test-defaults.js
Expand Up @@ -138,6 +138,17 @@ tape('del(string, function)', function(t) {
})
})

tape('delete(string, function)', function(t) {
request.defaults({
headers: {foo: 'bar'},
json: true
}).delete(s.url + '/', function (e, r, b) {
t.equal(b.method, 'DELETE')
t.equal(b.headers.foo, 'bar')
t.end()
})
})

tape('head(object, function)', function(t) {
request.defaults({
headers: { foo: 'bar' }
Expand Down

0 comments on commit 2ef974a

Please sign in to comment.