Skip to content

Commit

Permalink
2.61.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@simov
simov committed Aug 19, 2015
1 parent 8492d18 commit 58e8f53
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package.json
View file
Expand Up @@ -7,7 +7,7 @@
"util",
"utility"
],
"version": "2.61.0",
"version": "2.61.1",
"author": "Mikeal Rogers <mikeal.rogers@gmail.com>",
"repository": {
"type": "git",
Expand Down

7 comments on commit 58e8f53

@aamirafridi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spend 3 hours on fixing my jenkins built. Don't know what changed here but I fixed the issue...

Commit: you can't send a null object to request.defaults

Before:

const authRequest = request.defaults();
....
// results in this error:
// TypeError: Cannot read property 'pool' of undefined

After:

const authRequest = request.defaults({});

Looks like this was the issue ae403dc#diff-168726dbe96b3ce427e7fedce31bb0bcR91

@simov
Copy link
Member Author

@simov simov commented on 58e8f53 Aug 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit an issue about it, just point out which version you are using.

@aamirafridi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simov aamirafridi#1

@aamirafridi
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use "request": "^2.55.0"

@calibr
Copy link
Contributor

@calibr calibr commented on 58e8f53 Aug 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I think it's necessary to add a test for this situtation(when defaults() called without params) to prevent same problem in future.

@simov
Copy link
Member Author

@simov simov commented on 58e8f53 Aug 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calibr that's correct 👍

@simov
Copy link
Member Author

@simov simov commented on 58e8f53 Aug 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed here #1743

Please sign in to comment.