Skip to content

Commit

Permalink
Merge pull request #1436 from tikotzky/defaults-requester-without-opt…
Browse files Browse the repository at this point in the history
…ions

Add ability to set a requester without setting default options
  • Loading branch information
nylen committed Feb 19, 2015
2 parents 12c5376 + e8eb1e3 commit 8aede67
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
6 changes: 6 additions & 0 deletions index.js
Expand Up @@ -74,6 +74,12 @@ request.cookie = function (str) {
}

request.defaults = function (options, requester) {

if (typeof options === 'function') {
requester = options
options = {}
}

var self = this
var wrap = function (method) {
var headerlessOptions = function (options) {
Expand Down
17 changes: 17 additions & 0 deletions tests/test-defaults.js
Expand Up @@ -266,6 +266,23 @@ tape('test custom request handler function', function(t) {
})
})

tape('test custom request handler function without options', function(t) {
t.plan(1)

var customHandlerWithoutOptions = request.defaults(function(uri, options, callback) {
var params = request.initParams(uri, options, callback)
var headers = params.options.headers || {}
headers.x = 'y'
headers.foo = 'bar'
params.options.headers = headers
return request(params.uri, params.options, params.callback)
})

customHandlerWithoutOptions.get(s.url + '/get_custom', function(e, r, b) {
t.equal(e, null)
})
})

tape('test only setting undefined properties', function(t) {
request.defaults({
method: 'post',
Expand Down

0 comments on commit 8aede67

Please sign in to comment.