Merge pull request #1905 from simov/fix-body-buffer

Convert typed arrays into regular buffers

package.json

@@ -40,6 +40,7 @@
     "stringstream": "~0.0.4",
     "combined-stream": "~1.0.5",
     "isstream": "~0.1.2",
+    "is-typedarray": "~1.0.0",
     "har-validator": "~2.0.2"
   },
   "scripts": {

request.js

@@ -15,6 +15,7 @@ var http = require('http')
   , caseless = require('caseless')
   , ForeverAgent = require('forever-agent')
   , FormData = require('form-data')
+  , isTypedArray = require('is-typedarray').strict
   , helpers = require('./lib/helpers')
   , cookies = require('./lib/cookies')
   , getProxyFromURI = require('./lib/getProxyFromURI')
@@ -427,6 +428,10 @@ Request.prototype.init = function (options) {
   }
 
   function setContentLength () {
+    if (isTypedArray(self.body)) {
+      self.body = new Buffer(self.body)
+    }
+
     if (!self.hasHeader('content-length')) {
       var length
       if (typeof self.body === 'string') {

tests/test-body.js

@@ -3,6 +3,7 @@
 var server = require('./server')
   , request = require('../index')
   , tape = require('tape')
+  , http = require('http')
 
 var s = server.createServer()
 
@@ -144,6 +145,25 @@ addTest('testPutMultipartPostambleCRLF', {
     ]
 })
 
+tape('typed array', function (t) {
+  var server = http.createServer()
+  server.on('request', function (req, res) {
+    req.pipe(res)
+  })
+  server.listen(6768, function () {
+    var data = new Uint8Array([1, 2, 3])
+    request({
+      uri: 'http://localhost:6768',
+      method: 'POST',
+      body: data,
+      encoding: null
+    }, function (err, res, body) {
+      t.deepEqual(new Buffer(data), body)
+      server.close(t.end)
+    })
+  })
+})
+
 tape('cleanup', function(t) {
   s.close(function() {
     t.end()