Merge pull request #2426 from zertosh/remove-isfunction

Remove "isFunction" helper in favor of "typeof" check
request · Oct 17, 2016 · bb8e899 · bb8e899
2 parents a04f926 + 092e1e6
commit bb8e899
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/index.js b/index.js
@@ -18,8 +18,7 @@ var extend                = require('extend')
   , cookies               = require('./lib/cookies')
   , helpers               = require('./lib/helpers')
 
-var isFunction            = helpers.isFunction
-  , paramsHaveRequestBody = helpers.paramsHaveRequestBody
+var paramsHaveRequestBody = helpers.paramsHaveRequestBody
 
 
 // organize params for patch, post, put, head, del
@@ -95,7 +94,7 @@ function wrapRequestMethod (method, options, requester, verb) {
       target.method = verb.toUpperCase()
     }
 
-    if (isFunction(requester)) {
+    if (typeof requester === 'function') {
       method = requester
     }
 

diff --git a/lib/helpers.js b/lib/helpers.js
@@ -7,10 +7,6 @@ var defer = typeof setImmediate === 'undefined'
   ? process.nextTick
   : setImmediate
 
-function isFunction(value) {
-  return typeof value === 'function'
-}
-
 function paramsHaveRequestBody(params) {
   return (
     params.body ||
@@ -59,7 +55,6 @@ function version () {
   }
 }
 
-exports.isFunction            = isFunction
 exports.paramsHaveRequestBody = paramsHaveRequestBody
 exports.safeStringify         = safeStringify
 exports.md5                   = md5