Skip to content

Commit

Permalink
update per review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
aaron-em committed Mar 11, 2015
1 parent 8ce85f2 commit ddd3efb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
4 changes: 1 addition & 3 deletions request.js
Expand Up @@ -874,7 +874,6 @@ Request.prototype.start = function () {
// start() is called once we are ready to send the outgoing HTTP request.
// this is usually called on the first write(), end() or on nextTick()
var self = this
, startTime

if (self._aborted) {
return
Expand All @@ -898,11 +897,10 @@ Request.prototype.start = function () {

debug('make request', self.uri.href)

startTime = new Date().getTime()
self.req = self.httpModule.request(reqOptions)

if (self.timing) {
self.startTime = startTime
self.startTime = new Date().getTime()
}

if (self.timeout && !self.timeoutTimer) {
Expand Down
4 changes: 0 additions & 4 deletions tests/test-timing.js
Expand Up @@ -30,10 +30,6 @@ tape('setup', function(t) {
})
})

tape('no-op', function(t) {
t.end()
})

tape('non-redirected request is timed', function(t) {
var options = {time: true}
request('http://localhost:' + plain_server.port + '/', options, function(err, res, body) {
Expand Down

0 comments on commit ddd3efb

Please sign in to comment.