Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client side certificate doc mistake #1290

Closed
OferE opened this issue Nov 26, 2014 · 2 comments
Closed

client side certificate doc mistake #1290

OferE opened this issue Nov 26, 2014 · 2 comments

Comments

@OferE
Copy link

OferE commented Nov 26, 2014

There is a mistake in the documentation on how to use client side certificate.
The cert, key and passphrase should be given to the "options" object and not to the agentOptions.

I also created a pull request for this:
#1289

I didn't touch the SSLV3 paramters inside the agentOptions, so please also verify if this is the correct place for it.

I hope this helps.

@nylen
Copy link
Member

nylen commented Nov 28, 2014

I'm not familiar with these options. We really need to get some tests for them.

@nylen
Copy link
Member

nylen commented May 18, 2015

Fixed by #1585.

@nylen nylen closed this as completed May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants