Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing documentation regarding TLS options (#1583) #1585

Merged
merged 1 commit into from May 18, 2015

Conversation

mainakae
Copy link
Contributor

Fixing the documentation to recommend using options.ca, options.cer, options.key and options.passphrase instead of options.agentOptions. homologues, to avoid trouble in proxied environments, as commented in #1583

Fixing the documentation to recommend using `options.ca`, `options.cer`, `options.key` and `options.passphrase` instead of `options.agentOptions.` homologues, to avoid trouble in proxied environments, as commented in request#1583
@nylen
Copy link
Member

nylen commented May 17, 2015

This looks correct to me, and I think it will help address a number of other issues, as you said, #1289, #1490, #1290, #1229, #1236. However, I have not been following request closely for some months, @simov what do you think?

@simov
Copy link
Member

simov commented May 18, 2015

I'm for merging it, as it adds additional information instead of replacing parts of the documentation like it was in the previous PR.

@lalitkapoor
Copy link
Member

👍

@nylen
Copy link
Member

nylen commented May 18, 2015

Thanks @mainakae !!

nylen added a commit that referenced this pull request May 18, 2015
Fixing documentation regarding TLS options (#1583)
@nylen nylen merged commit b419de6 into request:master May 18, 2015
@mainakae
Copy link
Contributor Author

Great!, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants