Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getProxyFromURI might return false positive on detecting no-proxy element #1294

Closed
oliamb opened this issue Nov 28, 2014 · 4 comments
Closed

Comments

@oliamb
Copy link
Contributor

oliamb commented Nov 28, 2014

request.js:201-204

noProxyItem = noProxyItem.replace(/^\.*/, '.')
if (hostname.indexOf(noProxyItem) === hostname.length - noProxyItem.length) {
           return null         
}

when hostname.length - noProxyItem.length equals -1, this code actually do the opposite of what is wanted.

@nylen
Copy link
Member

nylen commented Nov 28, 2014

Fixed by #1295.

@nylen nylen closed this as completed Nov 28, 2014
@oliamb
Copy link
Contributor Author

oliamb commented Dec 1, 2014

Included in v >= 2.49.1

@nylen
Copy link
Member

nylen commented Dec 1, 2014

This one made it into 2.49.0 (release versions are always .0; master is always .1).

@oliamb
Copy link
Contributor Author

oliamb commented Dec 1, 2014

Oh, ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants