New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing unescape() from self._qs breaks requests with authentication #1619
Comments
That might be related to #1600 but tbh I don't see how's that possible. I need more context, can you provide a short code example that reproduces that bug? |
It seems that the "querystring" library supplied by Browserify does not include Refs: I'm closing this issue as it does not appear to be caused by a bug in this library. |
@andornaut did you find how to fix it on electron? i still get this error |
I note that unescape is deprecated: (reference) |
GET requests with http basic authentication credentials such as "http://user:pass@example.com" fail with error "self._qs.unescape is not a function".
This error occurs in request.js:
Changing
Querystring.prototype.unescape
to use the globalunescape()
ordecodeURIComponent
appears to resolve this issue.Environment: Electron 0.27.2 (chrome 43)
The text was updated successfully, but these errors were encountered: