Replace querystring.unescape with decodeURI #3148
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm test
locally and all tests are passing.PR Description
This addresses (closed) issues #1627 and #1619 which we also hit recently.
Our initial attempts to use
couchdb-nano
uncovered in this issue, where a URI with basic authorization in it was throwing the errorself._qs.unescape is not a function
.This may be due to webpack in our Vue.js environment.
To fix it on our end, I've simply replaced
self._qs.unescape
with thedecodeURI
standard javascript call. This now functions correctly in our environment. The issues above mention this issue in Electron builds, which are likely similar to our standard Vue.js (webpack) configuration. As mentioned by @stevage in #1627, I hope this is a benign and fairly straightforward change.This querystring.unescape call was referenced here:
#475 Use
unescape
fromquerystring
(@shimaore)Thanks!