Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Karma tests fail #2056

Closed
simov opened this issue Feb 4, 2016 · 2 comments · Fixed by #2058
Closed

Karma tests fail #2056

simov opened this issue Feb 4, 2016 · 2 comments · Fixed by #2058

Comments

@simov
Copy link
Member

simov commented Feb 4, 2016

@eiriksm both #2035 and #2044 are failing due to some weird error can you take a look at it? Just install those versions and you'll see the error. Thanks!
@eiriksm
Copy link
Member

eiriksm commented Feb 4, 2016

Sure! I'll take a look later today probably.

@eiriksm
Copy link
Member

eiriksm commented Feb 4, 2016

Opened #2058

@eiriksm eiriksm mentioned this issue Feb 4, 2016
Merged
eiriksm added a commit to eiriksm/request that referenced this issue Feb 5, 2016
@eiriksm
Upgrade karma-phantomjs-launcher and karma-browserify. Fix browser
3e63b90 
tests.

Fixes request#2035.
Fixes request#2044.
Closes request#2056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Karma fixes for latest versions eiriksm/request
2 participants
@eiriksm @simov