Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish and update to aws-sign2 0.6.1 #2483

Closed
thedevelopnik opened this issue Dec 7, 2016 · 5 comments
Closed

Publish and update to aws-sign2 0.6.1 #2483

thedevelopnik opened this issue Dec 7, 2016 · 5 comments
Labels

Comments

@thedevelopnik
Copy link

When using Rollup.js, the packing process breaks on the request dependency aws-sign2, because of a duplicate export.

Error parsing /node_modules/aws-sign2/index.js: Duplicate export 'queryStringToSign' (225:32) in /node_modules/aws-sign2/index.js

This issue has been fixed in aws-sign2, and there is an open issue on that repository to publish the new package. Right now anyone using request, or a package that uses request as a dependency (in our case Webdriver.io, node-gyp and selenium-standalone) cannot use Rollup (and possibly other similar products?) in their build process.

Fix should be as simple as publishing aws-sign2 and updating the package in request. Thank you!

@pastelsky
Copy link

Faced this issue today. A good number of libraries that depend on request cannot be used since rollup will simply fail to compile the project. Updating aws-sign2 would certainly be helpful.

@AndrewKvalheim
Copy link

Referencing #2635

@aschrijver
Copy link

aschrijver commented Aug 16, 2017

I am having this issue now, but since March there have not been new releases. Is this project dead? #2635 is not published yet.

@stale
Copy link

stale bot commented Nov 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2018
@stale stale bot closed this as completed Dec 4, 2018
@abhiramhatolkar
Copy link

The issue was fixed in version 0.7.0 of aws-sign. Here's the request. If you are getting the error when you include "request" package then you might be using the older version of request. I came across this issue when I was using request package version 0.81.0. I then upgraded it to 2.88.0 and it worked. Good luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants