Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documenting error handling when using streams #1237

Merged
merged 2 commits into from Nov 7, 2014
Merged

Documenting error handling when using streams #1237

merged 2 commits into from Nov 7, 2014

Conversation

vmattos
Copy link
Contributor

@vmattos vmattos commented Oct 30, 2014

No description provided.

@vmattos vmattos changed the title Documenting error handling when usnig streams Documenting error handling when using streams Oct 31, 2014
@FredKSchott
Copy link
Contributor

+1, but the use of handleError might confuse people, especially those who are copy and pasting. Could you replace it with a console log or a throw or just a // handle error here comment?

@vmattos
Copy link
Contributor Author

vmattos commented Nov 3, 2014

Yeah, sure!
Just done that

@FredKSchott
Copy link
Contributor

Awesome! +1 LGTM

FredKSchott added a commit that referenced this pull request Nov 7, 2014
@FredKSchott
Merge pull request #1237 from vmattos/doc/streamErrorHandling
c456b71 
Documenting error handling when using streams
@FredKSchott FredKSchott merged commit c456b71 into request:master Nov 7, 2014
@FredKSchott
Copy link
Contributor

Thanks @vmattos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmattos @FredKSchott