Fix multipart content-type headers detection #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simov
changed the title
|
Added one more test for the default Added a test for chunked On the other note - we should probably use a test coverage tool. |
|
I should use this on my own whenever I add new things master
multipart-mixed
|
|
👍 and 👍 to code coverage too. https://coveralls.io/ looks pretty nice, it will integrate with Travis and GitHub. https://github.com/cainus/node-coveralls is what they recommend for Node.js projects. |
nylen
added a commit
that referenced
this pull request
Nov 18, 2014
Fix multipart content-type headers detection
|
re: coverage tools - 👍 nice, I'll take a look at these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1274
Introduced in #1216 (v2.48)
There was a logical typo. I added tests for multipart content-type headers for both cases when the json option is present or not.