Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix changes introduced in https://github.com/request/request/pull/1282 #1310

Merged
merged 3 commits into from Dec 10, 2014
Merged

Fix changes introduced in https://github.com/request/request/pull/1282 #1310

merged 3 commits into from Dec 10, 2014
+45 −1

Commits on Dec 9, 2014

  1. Revert changes introduced in request#1282 

    For some reason this change brakes the form option when it's object
    @simov
    simov committed Dec 9, 2014
    Copy the full SHA
    f9f96e6 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2014

  1. Add application/x-www-form-urlencoded test where - 

    `form` is object, and `json` is set to `true`
Example:
{form: {some: 'url', encoded: 'data'}, json: true}
    @simov
    simov committed Dec 10, 2014
    Copy the full SHA
    2f33ed1 View commit details
    Browse the repository at this point in the history

  2. Disable body stringify in json method on - 

    application/x-www-form-urlencoded requests
as they have their body already stringified as url encoded string
inside the `form` method
    @simov
    simov committed Dec 10, 2014
    Copy the full SHA
    61c9d32 View commit details
    Browse the repository at this point in the history