Add clean script to remove test-browser.js after the tests run #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! I have that file hanging around in my repo for quite some time. |
|
Why not do this at the end of |
|
Nice, good catch @seanstrom |
|
+1 @nylen I totally didn't think of doing it after the test end. lol |
|
Would we want a clean-lint script at all? |
|
I don't see any need for |
|
Yup sounds good |
Whenever you run `npm test` it would generate a file. The location of the file would be `tests/browser/test-browser.js` which is a directory that the linter will lint. I tried making the linter ignore the file but it seems we're using an older version of the linter which may not support ignoring paths. I may be wrong but this was an alternative solution, safely delete the file before running the linter.
nylen
changed the title
nylen
added a commit
that referenced
this pull request
Jan 6, 2015
Add clean script to remove test-browser.js after the tests run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever you run
npm testit would generate a file.The location of the file would be
tests/browser/test-browser.jswhich is a directory that the linter will lint.
I tried making the linter ignore the file but it seems we're using
an older version of the linter which may not support ignoring paths.
I may be wrong but this was an alternative solution, safely delete
the file before running the linter.