Emit error when FormData emits an error event #1336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch error from FormData object and emit it as error event.
Fixed variable scope
Conflicts: request.js
|
That resolved conflict in the last commit looks kind of scary. Although the only problem might be the use of Also it would be nice to have a test for that. |
|
👍 to @simov's comments, we want this as a single commit, and it needs tests and a clean build. What happens now, is an error thrown? After this change, an error would still be thrown if users of Do we want to abort the request when this error occurs? |
|
Sorry about that the semi-colons were screwing up the test. I've created a less crappy PR #1341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When FormData emits an error event it's not emitted via request, I encountered this when using the Facebook graph API. FormData was emitting an error when the API failed but nothing was catching it.